Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] list to capture finish 要讓 user 知道該張 capture 已經 list 過 #1128

Closed
sync-by-unito bot opened this issue Dec 24, 2021 · 8 comments
Closed

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 24, 2021

Feature request:
建議作法擇一

  1. icon 顯示
  2. 讓 list 按鍵消失 ( 反灰不能再點選 )

Possible solution: [Issue] after list , still can choose "list" action

Supporting materials:
(請將輔助資訊貼入附件)

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

@sync-by-unito sync-by-unito bot changed the title [FR] list to capture finsh 要讓 user 知道該張 capture 已經 list 過 [FR] list to capture finish 要讓 user 知道該張 capture 已經 list 過 Feb 23, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 21, 2022

➤ Ray Hung commented:

James Chien Any suggestion on determining whether a Capture has been listed in Capture Club or not? I looked at the response from https://dia-backend.numbersprotocol.io/api/v3/redoc/#operation/assets_read ( https://dia-backend.numbersprotocol.io/api/v3/redoc/#operation/assets_read ) and don't see anything about this information.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 21, 2022

➤ Ray Hung commented:

Ethan Wu

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 21, 2022

➤ Ethan Wu commented:

You can do a search with List all Products API with associated_id parameter set to the assets cid.

Alternatively you can check Asset Details and see if the published parameter is True. (this one may need confirmation from James)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 21, 2022

➤ James Chien commented:

associated_id => checking this would be fine for asset-origin or asset-clone products, but if asset has only been listed as a series/pack-product, the product will not be in the returning list. In short: this will not work for assets only listed as series

published => the field is named before product API exist. It represents the mint status (yes => minted, no => not minted), so this has nothing to do with listing to CaptureClub

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 21, 2022

➤ Ray Hung commented:

James Chien Then what would you suggest to check assets that are only listed as series?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 21, 2022

➤ James Chien commented:

You can use list series API and check through all nested collection's if we want this feature implemented without any backend change. But adding a field in asset API will definitely be simpler and easier to maintain.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 23, 2022

➤ Ray Hung commented:

PR here: #1411 ( #1411 )

@sync-by-unito sync-by-unito bot closed this as completed Apr 17, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 17, 2022

➤ Tammy Yang commented:

merged, close the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants