Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Using JSON.stringify When Hash Objects in Storage Utils #150

Closed
seanwu1105 opened this issue Oct 29, 2020 · 1 comment · Fixed by #227
Closed

Avoid Using JSON.stringify When Hash Objects in Storage Utils #150

seanwu1105 opened this issue Oct 29, 2020 · 1 comment · Fixed by #227
Assignees
@seanwu1105
Labels
bug Something isn't working priority:high High priority
Milestone
backlog

Comments

@seanwu1105
Copy link
Contributor

Use sha256 is not a good idea as sha256$() uses JSON.stringify() under the hood. Thus, the order of the tuple (properties) will result in different hash if tuple is an array (object).

Maybe we need to use SQLite to save files.
@seanwu1105 seanwu1105 added bug Something isn't working priority:medium Medium priority labels Oct 29, 2020
@seanwu1105 seanwu1105 added this to the backlog milestone Oct 29, 2020
@seanwu1105 seanwu1105 added priority:high High priority and removed priority:medium Medium priority labels Oct 29, 2020
@seanwu1105
Copy link
Contributor Author

seanwu1105 commented Nov 11, 2020 •
edited
Loading

  • Abstract storage (store?) interface
  • Try RxDB

@seanwu1105 seanwu1105 self-assigned this Nov 17, 2020
@seanwu1105 seanwu1105 mentioned this issue Nov 17, 2020
Merged
@seanwu1105 seanwu1105 linked a pull request Nov 17, 2020 that will close this issue
Improve Stability and Reliability of Data Persistence #227
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanwu1105 seanwu1105

Labels
bug Something isn't working priority:high High priority
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

Improve Stability and Reliability of Data Persistence numbersprotocol/capture-lite
1 participant
@seanwu1105