Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] User can see a clear error message so that he can know he does't have sufficient NUM (For asset registration) #2601

Closed
sync-by-unito bot opened this issue Feb 16, 2023 · 18 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 16, 2023

Reproduce step

  1. Take a photo & press confirm.
  2. If the wallet amount is insufficient, it can't work (After 2/22 backend deployment)

Expectation
Have a error message when the asset registration process is fail.

Additional information:
https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764546162215424&cot=14
https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764546162215424&cot=14
User story
As a capture app old user without NUM token/credits, I want to know why I can't register the asset I create so that I won't feel this app is broken & leave this service.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title [Hot fixed] User can see a clear error message so that he can know he does't have sufficient NUM (For asset registration) [issue] User can see a clear error message so that he can know he does't have sufficient NUM (For asset registration) Feb 17, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Sam commented:

If the wallet amount is insufficient, it can't work (After 2/22 backend deployment).
Kenny Hung 2/22 backend is deployed?

In the miro Check user's asset wallet & credits is sufficient ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764546163409384&cot=14 ) is happening in the backend or client side (client side = capture app side)?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Kenny Hung commented:

Sam Yes, backend has been deployed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Sam commented:

Kenny Hung, so backend will prevent user from uploading a capture if balance is not enough?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Kenny Hung commented:

Sam (cc Scott Yan) As I know, yes. Because when user register the asset, backend will charge with user.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Sam commented:

Kenny Hung (cc: Scott Yan):
I did the following steps:

  1. created new account in production env
  2. capture photo Bump @capacitor/cli from 2.2.1 to 2.3.0 #1 (successfully uploaded to backend)
  3. capture photo Bump protractor from 5.4.4 to 7.0.0 #2 (successfully uploaded to backend)
  4. capture photo Bump @types/node from 12.12.50 to 14.0.23 #3 (successfully uploaded to backend)
  5. capture photo Bump karma from 5.0.9 to 5.1.0 #4 (successfully uploaded to backend)
  6. capture photo Bump karma-jasmine from 3.0.3 to 3.3.1 #5 (successfully uploaded to backend)

Assume I have some initial 3 credits I should be able to upload few photos for free right? How many newly created user can upload?

Because currently capture app uses this endpoint ( https://api.numbersprotocol.io/api/v3/assets/ ) to upload photos and it didn't give any error (already uploaded 5 photos)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Sam commented:

Kenny Hung, is there a way to check how much NUMs user charged for every capture upload.

I uploaded few captures and check balance and it seems like for every capture user pay ~0.02 NUM?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Kenny Hung commented:

Sam 0.025 + 0.0004 (gas fee) NUM

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Sam commented:

Kenny Hung, thank you for clarification. Currently I created new test account and it has 3 NUMs. I need to take too many photos until I make my NUMs = 0.

Do you have any accounts with 0 NUM points? for testing purposes?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Kenny Hung commented:

DM'ed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Sam commented:

Kenny Hung, do you have any error message suggestions?

Variant #1 (by ChatGPT)
"Oops! Looks like you don't have sufficient NUM to complete the asset registration. Please try again with sufficient NUM or contact customer support for assistance."

Variant #2 (by ChatGPT)
"Insufficient NUM balance. Please top up your balance to complete the asset registration."

Variant #3 (by ChatGPT)
"Oops! Looks like you don't have sufficient NUM to complete the asset registration. Please top up your balance and click resume registration button"

Variant #4 (by ChatGPT)
"You need more NUM to complete asset registration. Top up your balance and click 'Resume Registration'."

For now I used variant #2, Kenny Hung, please have a look if this is acceptable? If user has insufficient balance I will show error and pause upload.
https://app.claap.io/numbers-protocol/issue-user-can-see-a-clear-error-message-so-that-he-can-know-he-does-t-have-sufficient-num-for-asset-registration-preview-c-O35CsUM4Uy-rYmKSqwv6kkB#c-QFJ2vw2ik433m-bWbFBYv ( https://app.claap.io/numbers-protocol/issue-user-can-see-a-clear-error-message-so-that-he-can-know-he-does-t-have-sufficient-num-for-asset-registration-preview-c-O35CsUM4Uy-rYmKSqwv6kkB#c-QFJ2vw2ik433m-bWbFBYv )

@sync-by-unito sync-by-unito bot closed this as completed Mar 1, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 1, 2023

➤ Kenny Hung commented:

Sofia Yan Could you help to provide some suggestions?
I prefer #2😄

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 2, 2023

➤ Sofia Yan commented:

#2 is good.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 2, 2023

➤ Kenny Hung commented:

Sam for this task, please use #2, thanks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 2, 2023

➤ Sam commented:

Sofia Yan is google translate too wired😅?
NUM 餘額不足。 請充值您的餘額以完成資產登記。

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 2, 2023

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 2, 2023

➤ Sam commented:

I pasted google translate version for now

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Mar 9, 2023

➤ Sam commented:

For this task I just show error message here is the claap demo
https://app.claap.io/numbers-protocol/issue-user-can-see-a-clear-error-message-so-that-he-can-know-he-does-t-have-sufficient-num-for-asset-registration-preview-c-O35CsUM4Uy-rYmKSqwv6kkB ( https://app.claap.io/numbers-protocol/issue-user-can-see-a-clear-error-message-so-that-he-can-know-he-does-t-have-sufficient-num-for-asset-registration-preview-c-O35CsUM4Uy-rYmKSqwv6kkB )

Kenny Hung, I just saw miro 23.02.07 Insufficient balance UX ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764545537402879&cot=14 ). According to 23.02.07 Insufficient balance UX ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764545537402879&cot=14 ) miro we should show pop up.

For this task ✓ [issue] User can see a clear error message so that he can know he does't have sufficient NUM (For asset registration) ( https://app.asana.com/0/0/1203975293651132 ) should we show pop up or just error message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants