Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA workflow, allow to select shell variant, add checks, etc. #3

Closed
wants to merge 11 commits into from

Conversation

eine
Copy link
Contributor

@eine eine commented Oct 6, 2019

Close #1
Close #2

  • The first commit in this PR is picked from branch releases/v1.
  • @actions/core is updated to ^1.1.3.
  • eslint is removed from package.json, because it is not usable without a configuration file.
  • checks are added to ensure that the platform is windows (🤣) and that envvar RUNNER_TMP is not empty.
  • A GitHub Actions (GHA) workflow is added to test the action after each push or PR.
  • msysdo.cmd is first renamed to msysdo.in (for uses: ./ to work in the GHA workflow), but is then removed (by hardconding it in index.js).
  • An option named msystem is added to the action, to allow users to select the variant of MSYS2 to use. It defaults to MINGW64.
  • A test script (test.sh) is added and it is tested four times in the workflow: one with each allowed value of MSYSTEM and one without setting it explicitly.

@eine
Copy link
Contributor Author

eine commented Oct 8, 2019

Superseded by #6.

@eine eine closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safeguard: make sure this is invoked on a Windows machine Support executing a MSYS shell
2 participants