-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a bundler to simplify the deployment #4
Comments
I'm not sure I see the point of this. There are already very few files anyway. Also I think the fewer tools we use the easier it is for newcomers to contribute 😄 |
Are you sure? There are currently ~275 files (14.3MB) in the release, and the relevant files account for 3.15KB. It is true that it is a low number for a typical JavaScript application. However, the JS ecosystem being so bad-performing shouldn't prevent us from being kind with bandwidth and disk usage. Moreover, the current list of files is subject to change (content of
Note that #5 is based on Nonetheless, newcomers can ignore this feature completely. This is only relevant for deployment/releases. Therefore, only maintainers need to be aware of it. Developers who are not maintainers can still execute |
I'm closing this because #5 (which is part of eine/setup-msys2) has been tested for some months and it works as expected. |
By using a bundler, such as webpack, the deployment can be reduced to three files:
main.js
,action.yml
andREADME.md
. See, for example: https://github.com/1138-4EB/issue-runner/tree/gha-tipThe text was updated successfully, but these errors were encountered: