Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all the analyzers #205

Closed
mikkelbu opened this issue Apr 23, 2020 · 2 comments · Fixed by #206
Closed

Document all the analyzers #205

mikkelbu opened this issue Apr 23, 2020 · 2 comments · Fixed by #206
Assignees
Milestone

Comments

@mikkelbu
Copy link
Member

We have 18 that needs information instead of "ADD MOTIVATION HERE" and "ADD HOW TO FIX VIOLATIONS HERE"

@SeanKilleen
Copy link
Member

@mikkelbu I believe my #206 PR might close this out if we tweak the language to address the motivation sections. I welcome your feedback there to extract the motivation from my examples. Once I understand the purpose of the motivation section better, I think we might be able to close this issue out.

@mikkelbu
Copy link
Member Author

Most of the motivations - at least for the diagnostics that are marked as errors - is that the code would fail at runtime or mark the test as not runnable (depending on how you run the test). I'll review the PR now and make some comments. But I'm already thankful for the contribution 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants