Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compromise license patch 1 #13

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Compromise license patch 1 #13

merged 2 commits into from
Oct 28, 2021

Conversation

Daasin
Copy link
Contributor

@Daasin Daasin commented Oct 27, 2021

(Amended to be MIT and/or Apache 2.0 for review @nuta )

@Daasin Daasin marked this pull request as ready for review October 27, 2021 20:39
LICENSE.md Show resolved Hide resolved
@lain-dono
Copy link

Why not just split them into two files? As in cargo, wgpu, log, etc.

Note that all these projects use "MIT OR Apache 2.0". See Crates.toml.

For more info, see:
Rust API Guidelines
Rust FAQ

@nuta nuta merged commit 3d23db1 into nuta:main Oct 28, 2021
@nuta
Copy link
Owner

nuta commented Oct 28, 2021

Why not just split them into two files? As in cargo, wgpu, log, etc.

Note that all these projects use "MIT OR Apache 2.0". See Crates.toml.

For more info, see: Rust API Guidelines Rust FAQ

I think splitting into separate files is not a big deal. Adding the license field sounds a good idea by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants