Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module): inject $ga in ctx #40

Merged
merged 1 commit into from
Feb 26, 2019
Merged

feat(module): inject $ga in ctx #40

merged 1 commit into from
Feb 26, 2019

Conversation

ricardogobbosouza
Copy link
Member

Resolve #11

@manniL manniL requested review from MatteoGabriele and pi0 February 25, 2019 23:46
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files           1        1           
  Lines          13       13           
  Branches        4        4           
=======================================
  Hits            9        9           
  Misses          2        2           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed7df7...ee3f733. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 25, 2019 •
edited
Loading

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files           1        1           
  Lines          13       13           
  Branches        4        4           
=======================================
  Hits            9        9           
  Misses          2        2           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed7df7...ee3f733. Read the comment docs.

galvez
galvez approved these changes Feb 26, 2019
View reviewed changes
Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @ricardogobbosouza!

@pi0 pi0 merged commit 2c42bf3 into nuxt-community:master Feb 26, 2019
@ricardogobbosouza ricardogobbosouza deleted the patch-1 branch March 1, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@galvez galvez galvez approved these changes

@MatteoGabriele MatteoGabriele Awaiting requested review from MatteoGabriele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardogobbosouza @galvez @pi0