Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements #1

Merged
merged 10 commits into from
Apr 15, 2020
Merged

feat: improvements #1

merged 10 commits into from
Apr 15, 2020

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Apr 15, 2020

  • Prebuild global script
    • Remove dependency on terser
    • ES6 syntax
  • Use global variable shortcuts and tiny improvements to reduce global script size by %18
  • $colorMode.unknown to easily check SSR+system state
    • Always set to true on SSR when the target is static
  • Update example to directly SSR render if state is not unknown
  • General code refactors
  • Templates are now lintable
  • new hid and globalName options
    • docs
  • <color-scheme> component to smartly avoid flash (only static or when SSR default is system)

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines           18        20    +2     
  Branches         3         3           
=========================================
+ Hits            18        20    +2     
Impacted Files Coverage Δ
lib/module.js 100.00% <100.00%> (ø)
lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3439d71...33b61cc. Read the comment docs.

@atinux atinux merged commit be3dd4b into master Apr 15, 2020
@atinux atinux deleted the improvements branch April 15, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants