fix: remove "encodePaths" option and don't encode paths by default #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be considered a breaking change but since I only know of it breaking things rather than helping anything and there are no tests that would prove me otherwise, I think it's safe to remove without releasing a major version. Also, Nuxt doesn't encode paths either so this change aligns with it. Resolves #712
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 3 3
Lines 125 125
Branches 34 33 -1
=======================================
Hits 122 122
Misses 3 3
Continue to review full report at Codecov.
|
|
Paths encoding was fixing issue #7 but that one doesn't reproduce in latest Nuxt anymore so I'm even more confident in getting rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be considered a breaking change but since I only know of it
breaking things rather than helping anything and there are no tests that
would prove me otherwise, I think it's safe to remove without releasing
a major version.
Also, Nuxt doesn't encode paths either so this change aligns with it.
Resolves #712