Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head doesn't reset per page generation when using classic static + nuxt 2.11, but does in 2.14.4 #4

Closed
hecktarzuli opened this issue Sep 1, 2020 · 2 comments · Fixed by #5

Comments

@hecktarzuli
Copy link
Collaborator

hecktarzuli commented Sep 1, 2020

When using this module on a Nuxt 2.11 site (target: server, mode: 'universal', 'generate') the metas don't seem to be reset per page generation.

It's almost like we need to manually check for the meta to exist ourselves which is strange.
https://github.com/nuxt-community/speedcurve-module/blob/master/lib/templates/plugin.js#L80

image

After updating my site to Nuxt 2.14.4, it looks fine. Did something change since 2.11?

@hecktarzuli
Copy link
Collaborator Author

@pi0 @pimlie was there some type of problem with metas not getting reset per page (and then get resolved) between 2.11 and 2.14.4?

@hecktarzuli hecktarzuli changed the title Head duplicates when using classic static + nuxt 2.11, but not 2.14.4 Head doesn't reset per page generation when using classic static + nuxt 2.11, but not 2.14.4 Sep 1, 2020
@hecktarzuli hecktarzuli changed the title Head doesn't reset per page generation when using classic static + nuxt 2.11, but not 2.14.4 Head doesn't reset per page generation when using classic static + nuxt 2.11, but does in 2.14.4 Sep 1, 2020
@pi0
Copy link
Member

pi0 commented Sep 1, 2020

Hi @hecktarzuli indeed it was a bug fixed by 2.12 (nuxt/nuxt#6807)

You can add a notice to the docs or do nuxt-community/gtm-module@43f41c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants