Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support typescript runtime #164

Merged
merged 1 commit into from
Nov 10, 2020
Merged

feat: support typescript runtime #164

merged 1 commit into from
Nov 10, 2020

Conversation

farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Nov 3, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Nuxt always runs commands using node therefore running nuxt-ts storybook does not work as expected. With this PR @nuxtjs/storybook will check tscofnig.json and register ts-node when it's required.

close #160

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@farnabaz farnabaz requested a review from pi0 November 3, 2020 14:47
@ErickPetru ErickPetru mentioned this pull request Nov 5, 2020
Closed
pi0
pi0 approved these changes Nov 6, 2020
View reviewed changes
Copy link

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@farnabaz farnabaz merged commit 1e3a659 into master Nov 10, 2020
@farnabaz farnabaz deleted the typescript branch November 10, 2020 09:30
@farnabaz farnabaz mentioned this pull request Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use with nuxt.config.ts and Nuxt Typescript?
2 participants
@farnabaz @pi0