Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-app): rename transition to pageTransition and deprecate it #5558

Merged
merged 3 commits into from
Apr 20, 2019

Conversation

atinux
Copy link
Member

@atinux atinux commented Apr 18, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Following this tweet: https://twitter.com/Atinux/status/1118789460253184000?s=19
Since we have layoutTransition, it makes more sense to rename transition to pageTransition in nuxt.config.js

I also added a warning for those using transition in order to rename it:
Screenshot 2019-04-18 at 14 01 44

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@atinux atinux requested review from TheAlexLichter and a team April 18, 2019 12:24
Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests seems to be failing, you probably need to change few other things to fix them 😁

@pi0 pi0 changed the title feat(vue-app): Rename transition to pageTransition and deprecate it feat(vue-app): rename transition to pageTransition and deprecate it Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants