Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vue-renderer): remove chalk in renderer #5609

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Apr 26, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Remove warning WARN 'chalk' is imported by packages\vue-renderer\src\renderer.js, but could not be resolved – treating it as an external dependency

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 April 26, 2019 11:16
pi0
pi0 previously approved these changes Apr 26, 2019
@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #5609 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #5609   +/-   ##
=====================================
  Coverage   95.7%   95.7%           
=====================================
  Files         81      81           
  Lines       2633    2633           
  Branches     670     670           
=====================================
  Hits        2520    2520           
  Misses        95      95           
  Partials      18      18
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 93.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3539c64...1e9d359. Read the comment docs.

@pi0 pi0 merged commit b7284e1 into nuxt:dev Apr 26, 2019
@pi0 pi0 mentioned this pull request May 9, 2019
@clarkdo clarkdo deleted the refactor/chalk-in-renderer branch September 7, 2019 21:53
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants