Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using aliases in templates #5656

Merged
merged 3 commits into from
May 6, 2019
Merged

fix: avoid using aliases in templates #5656

merged 3 commits into from
May 6, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 4, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5649.

Related PR #5655.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from clarkdo, atinux and a team May 4, 2019 22:22
@pi0 pi0 mentioned this pull request May 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #5656 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5656      +/-   ##
=========================================
- Coverage   95.74%   95.7%   -0.04%     
=========================================
  Files          81      81              
  Lines        2633    2633              
  Branches      670     670              
=========================================
- Hits         2521    2520       -1     
- Misses         94      95       +1     
  Partials       18      18
Impacted Files Coverage Δ
packages/builder/src/context/template.js 100% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 93.49% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c7fe8...4770db7. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 4, 2019

Codecov Report

Merging #5656 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5656      +/-   ##
=========================================
- Coverage   95.74%   95.7%   -0.04%     
=========================================
  Files          81      81              
  Lines        2633    2633              
  Branches      670     670              
=========================================
- Hits         2521    2520       -1     
- Misses         94      95       +1     
  Partials       18      18
Impacted Files Coverage Δ
packages/builder/src/context/template.js 100% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 93.49% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c7fe8...4770db7. Read the comment docs.

Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pi0 pi0 marked this pull request as ready for review May 5, 2019 06:45
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make '@' alias configurable
5 participants