Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples(auth-jwt): use named store export to prevent warning #5775

Merged
merged 1 commit into from
May 21, 2019

Conversation

alexandreDavid
Copy link

@alexandreDavid alexandreDavid commented May 21, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The auth-jwt example provides a warning message for deprecated synthax in the console.
Just adjusting the code as explained in the documentation.

Remove the console message

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #5775 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5775      +/-   ##
==========================================
+ Coverage   95.64%   95.67%   +0.03%     
==========================================
  Files          82       82              
  Lines        2661     2661              
  Branches      682      682              
==========================================
+ Hits         2545     2546       +1     
+ Misses         98       97       -1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.69% <ø> (ø) ⬆️
#unit 92.63% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a764e1f...d61e06c. Read the comment docs.

@atinux atinux changed the title Bug fix - Remove the console warning in the auth-jwt example misc(examples): remove console warning in the auth-jwt example May 21, 2019
@atinux atinux self-requested a review May 21, 2019 13:53
@pi0 pi0 changed the title misc(examples): remove console warning in the auth-jwt example examples(auth-jwt): remove console warning in the auth-jwt example May 21, 2019
@pi0 pi0 changed the title examples(auth-jwt): remove console warning in the auth-jwt example examples(auth-jwt): use named store export to prevent warning May 21, 2019
@pi0 pi0 merged commit 0e48eb6 into nuxt:dev May 21, 2019
This was referenced May 21, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants