Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve build indicator #5832

Merged
merged 34 commits into from
May 30, 2019
Merged

refactor: improve build indicator #5832

merged 34 commits into from
May 30, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 30, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • When Nuxt server is restarted, websocket connection is lost. This PR improves timeout/reconnect handling
  • Disable build indicator for programmatic users as they don't setup websocket.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #5832 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5832      +/-   ##
==========================================
+ Coverage   95.68%   95.68%   +<.01%     
==========================================
  Files          82       82              
  Lines        2687     2690       +3     
  Branches      689      690       +1     
==========================================
+ Hits         2571     2574       +3     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.37% <0%> (-0.06%) ⬇️
#unit 92.67% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/cli/src/command.js 98.98% <100%> (+0.01%) ⬆️
packages/config/src/options.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d149e9f...82b275b. Read the comment docs.

@atinux atinux self-requested a review May 30, 2019 10:01
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes 👍

@pi0 pi0 merged commit f39fe22 into dev May 30, 2019
@pi0 pi0 deleted the feat/hmr-indicator branch May 30, 2019 10:04
@pi0 pi0 mentioned this pull request May 30, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants