Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevent both nuxt & nuxt-edge being installed #6020

Merged
merged 3 commits into from
Jul 4, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 2, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolve issue caused by installing nuxt & nuxt-edge at same time, like #5996

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team July 2, 2019 15:32
@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #6020 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6020      +/-   ##
==========================================
+ Coverage   95.68%   95.69%   +<.01%     
==========================================
  Files          82       82              
  Lines        2689     2693       +4     
  Branches      690      692       +2     
==========================================
+ Hits         2573     2577       +4     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.27% <0%> (-0.08%) ⬇️
#unit 92.68% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/cli/src/run.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac723e6...b868a19. Read the comment docs.

atinux
atinux previously approved these changes Jul 3, 2019
Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, the error message says please remove the unused one

This is an assumption, eg the user might be trying to use both at the same time. Maybe better to say something like Both nuxt as nuxt-edge are installed. This is unsupported, please choose one and uninstall the other.

@pi0 pi0 requested review from atinux and pimlie July 4, 2019 12:48
@pi0 pi0 changed the title fix: prevent both nuxt & nuxt-edge being installed fix(cli): prevent both nuxt & nuxt-edge being installed Jul 4, 2019
Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@clarkdo
Copy link
Member Author

clarkdo commented Jul 4, 2019

@pi0 @pimlie 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants