-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-app): use EventSource instead of WebSocket for build indicator #6186
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6186 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 80 80
Lines 2655 2655
Branches 683 683
=======================================
Hits 2542 2542
Misses 97 97
Partials 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…sockets
Types of changes
Description
EventSource are better than Websockets and avoid the limitation of X connected sockets, might also solve Nuxt hanging on reload.
loading-screen
dependency.Checklist: