-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-renderer): call render:resourcesLoaded
hook before createRenderer
#6223
Conversation
render:resourcesLoaded
hook before createRenderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for CI... thanks :)
I was also thinking to make it possible dynamically changing |
Function publicPath? |
@clarkdo no. simply updating the value from loaded config. which can be set differently at production. currently it is loaded from dist manifest. |
Also need a manual updating step at runtime? |
by nuxt :) WIll create a PR after this :) |
@pi0 could you ping me when you make this PR. Thanks! |
@clarkdo Is changing |
For spa, since browser has not interaction after first page request, so even you change the publicPath, the client side can't know the changes before a page reload. Could try refreshing the page ? If it still doesn't work, could you provide a repo ? |
Well ideally it would be that The other solution would be that Nuxt gets support for |
Types of changes
Description
Resloves #5960, move hook before renderers creation, provide possibility to change resources at runtime.
Checklist: