feat(vue-app): function watchQuery #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fear the watchQuery function indeed very much 😆 |
|
？ |
|
See the PR title |
Codecov Report
@@ Coverage Diff @@
## dev #6297 +/- ##
=====================================
Coverage 95.7% 95.7%
=====================================
Files 79 79
Lines 2652 2652
Branches 683 683
=====================================
Hits 2538 2538
Misses 98 98
Partials 16 16
Continue to review full report at Codecov.
|
|
Opps😱 |
pimlie
reviewed
Aug 28, 2019
packages/vue-app/template/client.js
Outdated
| @@ -279,6 +279,7 @@ async function render(to, from, next) { | |||
| // Get route's matched components | |||
| const matches = [] | |||
| const Components = getMatchedComponents(to, matches) | |||
| const instances = getMatchedComponentsInstances(to) | |||
There was a problem hiding this comment.
Could this be moved to the watchQuery else if (eg using memoization)?
The need for instances is for such a specific use-case only that we shouldnt always spent those cpu cycles retrieving them when there is a reasonable chance we dont need them
Merged
This was referenced Nov 12, 2019
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Be merged after 2.9.2
Checklist: