chore(cli): rename setup hook to run:before #6363
Conversation
| @@ -36,7 +36,7 @@ export default class NuxtCommand extends Hookable { | |||
| } | |||
|
|
|||
| async run () { | |||
| await this.callHook('setup', { | |||
| await this.callHook('run:before', { | |||
There was a problem hiding this comment.
This will be a breaking change for ts module users that only upgrade their nuxt. Is this OK? (I think for an internal hook like this setup name is just fine)
so still merge this? :)
There was a problem hiding this comment.
@pi0 Well current last Nuxt release has setup hook not called at the really wanted place, and Nuxt TS with hooks is only draft PR.
We talked about breaking change indeed for people upgrading TS runtime but not Nuxt, but we said we want to force user to use last hooky Nuxt version , so all good no ? 😁
There was a problem hiding this comment.
Yep! I thought TS module was released with setup hook. So seems good!
Codecov Report
@@ Coverage Diff @@
## dev #6363 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 79 79
Lines 2666 2666
Branches 683 683
=======================================
Hits 2552 2552
Misses 98 98
Partials 16 16
Continue to review full report at Codecov.
|
Description
Rename
setupCLI hook torun:beforeto better fit the context where it's called.Checklist: