Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config, vue-app): add module declaration for config and vue-app #6379

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 8, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Fix error: File 'config/index.d.ts' is not a module.

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from kevinmarrec September 8, 2019 18:37
@kevinmarrec
Copy link
Contributor

@clarkdo Where have you been able to see such error ? 🤔

@clarkdo
Copy link
Member Author

clarkdo commented Sep 8, 2019

tsconfig.json with "noImplicitAny": true

I'm using @nuxt/config or vue-app in dev mode (import from source), not from node_modules

@clarkdo clarkdo requested a review from pi0 September 8, 2019 18:51
@pi0 pi0 changed the title fix(ts): add module declaration for config and vue-app fix(config, vue-app): add module declaration for config and vue-app Sep 9, 2019
@pi0 pi0 merged commit eadde4e into dev Sep 9, 2019
@pi0 pi0 deleted the fix/missing-module branch September 9, 2019 07:31
@pi0 pi0 mentioned this pull request Sep 26, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants