-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add config option to define etag hash function #6438
Merged
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimlie
commented
Sep 19, 2019
pimlie
changed the title
feat: add hook for overriding default etag hash
feat(server): add hook for overriding default etag hash
Sep 19, 2019
Codecov Report
@@ Coverage Diff @@
## dev #6438 +/- ##
=========================================
+ Coverage 95.6% 95.61% +0.01%
=========================================
Files 79 79
Lines 2684 2693 +9
Branches 692 697 +5
=========================================
+ Hits 2566 2575 +9
Misses 101 101
Partials 17 17
Continue to review full report at Codecov.
|
pimlie
changed the title
feat(server): add hook for overriding default etag hash
feat(server): add config option to define etag hash function
Sep 20, 2019
pi0
reviewed
Sep 20, 2019
Co-Authored-By: Pooya Parsa <pyapar@gmail.com>
pi0
approved these changes
Sep 20, 2019
Merged
This was referenced Nov 12, 2019
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
While looking into some benchmarks, @aldarund found out that generating the etag could snoop up a lot of processing time (especially with large html, ie
extractCss: false
). Further investigation found that the etag module usesSHA1
for generating a hash of the full html body.This pr introduces a new config option
render.etag.hash
which users can use to implement their own etag hash function. Ie for etags it should often be fine to use a non-cryptographic hash function like murmurhash, which is multiple times faster with larger html body sizes.Note: the
render.etag.weak
option is ignored when using the hook, user is responsible for implementing that.Example for using murmurhash-native instead:
Checklist: