Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-app): resolve leave transition on child routes #6803

Merged
merged 4 commits into from
Jan 10, 2020
Merged

fix(vue-app): resolve leave transition on child routes #6803

merged 4 commits into from
Jan 10, 2020

Conversation

atinux
Copy link
Member

@atinux atinux commented Dec 17, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #6788

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@atinux atinux changed the title fix: resolves leave transition on child routes fix(vue-app): resolves leave transition on child routes Dec 18, 2019
@atinux atinux requested review from pi0 and clarkdo December 18, 2019 10:36
@atinux
Copy link
Member Author

atinux commented Dec 18, 2019

I need to fix the failing tests before your reviews :)

@atinux
Copy link
Member Author

atinux commented Dec 19, 2019

Ready for review @pi0

@pi0 pi0 merged commit c9beac3 into dev Jan 10, 2020
@pi0 pi0 changed the title fix(vue-app): resolves leave transition on child routes fix(vue-app): resolve leave transition on child routes Jan 10, 2020
@reegodev reegodev mentioned this pull request Feb 7, 2020
Merged
7 tasks
@clarkdo clarkdo deleted the fix-transitions-child branch February 19, 2020 09:44
@pi0 pi0 mentioned this pull request Feb 25, 2020
Merged
This was referenced Mar 20, 2020
Merged
Open
This was referenced Mar 28, 2020
Merged
Merged
This was referenced Apr 8, 2020
Closed
Closed
Closed
Open
Merged
Open
Open
Open
Open
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@clarkdo clarkdo Awaiting requested review from clarkdo

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leave transitions are broken on child routes
3 participants
@atinux @pi0 @danielroe