Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioGroup): props reactivity issues #1065

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Dec 5, 2023

πŸ”— Linked issue

Fixes #1053

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This changes the condition to disable the FormGroup's label binding on RadioGroup's to fix reactivity issues on props caused by the spread operator.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Dec 5, 2023 5:19pm

@benjamincanac benjamincanac changed the title fix(RadioGroup): fixed props reactivity issues fix(RadioGroup): props reactivity issues Dec 6, 2023
@benjamincanac benjamincanac merged commit 7196d81 into dev Dec 6, 2023
2 checks passed
@benjamincanac benjamincanac deleted the fix-radio-group-props-reactivity branch December 6, 2023 16:15
@benjamincanac
Copy link
Member

Thanks @romhml! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RadioGroup] Setting color does not work
2 participants