Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Carousel): add tab-based ARIA roles #1516

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

nmggithub
Copy link
Contributor

@nmggithub nmggithub commented Mar 14, 2024

πŸ”— Linked issue

Resolves #1484.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

According to the W3C ARIA Authoring Practices Guide, specifically the page on the Carousel pattern using tab-based ARIA roles is one of the suggested uses of ARIA. This uses that ARIA pattern for the specific Carousel use-case with indicators (as that is what the APA is talking about when it refers to a "tabbed" carousel).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix(aria): add aria to "tabbed" carousel fix(Carousel): add tab-based ARIA roles Mar 14, 2024
@benjamincanac benjamincanac merged commit e736eca into nuxt:dev Mar 14, 2024
2 checks passed
Copy link
Member

Thanks! 😊

@ramsesndame237
Copy link

is possible to add and autoplay fonctionnality to the carousel ?

Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel component could be made more accessible.
3 participants