fix(Dropdown/Popover): conflict in toggle for touch devices #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when on a touch device, the "onTouchStart" function opens the DropDown AND also, the "click" handler tries toggling the DropDown, so it closes the Dropdown
- when on a touch device, the "onTouchStart" function opens the Popover AND also, the "click" handler tries toggling the Popover, so it closes the Popover
|
@DanielQolami Is this also supposed to fix #2097, #1823 and #1337? |
benjamincanac
changed the title
benjamincanac
approved these changes
Sep 30, 2024
Yes. It supports the fix on all three issues. I read those issues and tried their "reproduction"s. as they all say in their comments, it doesn't works on touch devices when they click on the "trigger" button, but if they hold their finger on the "trigger" button and drag their finger to aside, only "onTouchStart" would be triggered and the dropdown/popover visibility would be toggled. This pull request will fix that. |
|
Thank you! 😊 |
patrick-hofmann
pushed a commit
to patrick-hofmann/nuxt-ui
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #2261, resolves #2097, resolves #1823 and resolves #1337
❓ Type of change
📚 Description
In the UDropdown & UPopover components, when you are in a touch device, clicking on the trigger button, doesn't do anything. because the "click" event & "touchstart" event conflict with each other.
so I add a gaurd in "onTouchStart" function to do a check if "props.mode === 'click'", return from the function.
📝 Checklist