Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): handle dot nation with by prop #2413

Merged
merged 11 commits into from
Oct 19, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Oct 18, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi, I just added a small function called accessor that allows accessing an object using the dot notation. It will be used in a comparison function so that users can compare nested objects. For example:

<script setup lang="ts">
const people = [{
  id: 1,
  name: 'Lindsay Walton',
  title: 'Front-end Developer',
  email: 'lindsay.walton@example.com',
  role: 'Member',
  customer: {
    id: '1'
  }
]

const selected = ref([people[0])
</script>

<template>
  <UTable v-model="selected" :rows="people" by="customer.id" />
</template>

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar changed the title Feat(Table): enhancement function comparator feat(Table): enhancement function comparator Oct 18, 2024
@rdjanuar rdjanuar changed the title feat(Table): enhancement function comparator feat(Table): enhancement function 'comparator' Oct 18, 2024
@rdjanuar rdjanuar changed the title feat(Table): enhancement function 'comparator' feat(Table): enhancement function comparator Oct 18, 2024
@rdjanuar
Copy link
Collaborator Author

i think i can extend function get in utils

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the diff on both package.json and pnpm-lock.yaml?

@rdjanuar
Copy link
Collaborator Author

pnpm done but for package json i dont know what`s the diffrence. if i remove curly bracker it will error @benjamincanac

Copy link
Member

It's just the EOL

@rdjanuar
Copy link
Collaborator Author

i change EOL from LF to CRLF it`s update everything :)) in package json @benjamincanac

@rdjanuar
Copy link
Collaborator Author

Sorry, Would you mind helping me fix this issue? @benjamincanac

@benjamincanac benjamincanac changed the title feat(Table): enhancement function comparator fix(Table): handle dot nation with by prop Oct 19, 2024
@benjamincanac benjamincanac merged commit b72d343 into nuxt:dev Oct 19, 2024
1 of 2 checks passed
@benjamincanac
Copy link
Member

Done! Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants