Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectMenu): fixes non-strings and nested searchable attributes #967

Merged

Conversation

DarkGhostHunter
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently, <USelectMenu> attribute search-attributes doesn't work when the property to search is a non-string, or is nested.

This fixes that behavior:

  • The attribute uses the get internal utility to find the nested attribute if it's not a string or number.
  • It uses the String constructor to cast the Object/Array option to a string.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Nov 21, 2023 9:30pm

@DarkGhostHunter
Copy link
Contributor Author

DarkGhostHunter commented Nov 21, 2023

@benjamincanac Everything fixed. The prop type is left as-is. The only fix is getting the property value using get, and the documentation.

@benjamincanac benjamincanac merged commit 37fdf22 into nuxt:dev Nov 21, 2023
1 of 2 checks passed
Copy link
Member

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants