-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SelectMenu): fixes non-strings and nested searchable attributes #967
Merged
benjamincanac
merged 3 commits into
nuxt:dev
from
DarkGhostHunter:fix/selectmenu-searchattributes
Nov 21, 2023
Merged
fix(SelectMenu): fixes non-strings and nested searchable attributes #967
benjamincanac
merged 3 commits into
nuxt:dev
from
DarkGhostHunter:fix/selectmenu-searchattributes
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
DarkGhostHunter
force-pushed
the
fix/selectmenu-searchattributes
branch
from
November 15, 2023 17:13
b6a0788
to
14344b0
Compare
DarkGhostHunter
force-pushed
the
fix/selectmenu-searchattributes
branch
from
November 21, 2023 19:35
86f0a45
to
b4b91f4
Compare
@benjamincanac Everything fixed. The prop type is left as-is. The only fix is getting the property value using |
benjamincanac
approved these changes
Nov 21, 2023
Thanks! π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Currently,
<USelectMenu>
attributesearch-attributes
doesn't work when the property to search is a non-string, or is nested.This fixes that behavior:
get
internal utility to find the nested attribute if it's not a string or number.String
constructor to cast the Object/Array option to a string.π Checklist