From 8375b037d8c81aaca6bf26b03cac58433b631ff5 Mon Sep 17 00:00:00 2001 From: Bill Dengler Date: Fri, 23 Aug 2024 15:31:41 -0700 Subject: [PATCH] Revert "Use UIA caret events in Windows Terminal (#16873)" This reverts commit 067c8a96cb959fbeb28c0eba7feaccb4700d0e87. --- source/NVDAObjects/UIA/winConsoleUIA.py | 4 ---- user_docs/en/changes.md | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/source/NVDAObjects/UIA/winConsoleUIA.py b/source/NVDAObjects/UIA/winConsoleUIA.py index 9674f590aaf..62f131d0e98 100644 --- a/source/NVDAObjects/UIA/winConsoleUIA.py +++ b/source/NVDAObjects/UIA/winConsoleUIA.py @@ -450,10 +450,6 @@ def event_UIA_notification(self, **kwargs): "Block notification events when diffing to prevent double reporting." log.debugWarning(f"Notification event blocked to avoid double-report: {kwargs}") - def _get_caretMovementDetectionUsesEvents(self) -> bool: - "Windows Terminal has a good implementation of caret move detection." - return True - class _NotificationsBasedWinTerminalUIA(UIA): """ diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index c2fafcd3b50..1e24e6efc73 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -27,10 +27,12 @@ The available options are: ### Bug Fixes +* NVDA once again relies on UIA events for caret movement in XAML and WPF text controls, rather than only on manual querying of the caret position. (#16817, @LeonarddeR) +* The Seika Notetaker driver now correctly generates braille input for space, backspace and dots with space/backspace gestures. (#16642, @school510587) +* In on-demand speech mode, NVDA does not talk anymore when a message is opened in Outlook, when a new page is loaded in a browser or during the slideshow in PowerPoint. (#16825, @CyrilleB79) * NVDA once again relies on events for caret movement in several cases, rather than only on manual querying of the caret position. * UIA for XAML and WPF text controls. (#16817, @LeonarddeR) * IAccessible2 for browsers such as Firefox and Chromium based browsers. (#11545, #16815, @LeonarddeR) - * UIA in Windows Terminal. (#16873, @codeofdusk) * When accessing Microsoft Word without UI Automation, NVDA no longer outputs garbage characters in braille in table headers defined with the set row and column header commands. (#7212) * The Seika Notetaker driver now correctly generates braille input for space, backspace and dots with space/backspace gestures. (#16642, @school510587) * Braille cursor routing is now much more reliable when a line contains one or more Unicode variation selectors or decomposed characters. (#10960, @mltony, @LeonarddeR)