Update target to net8 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlh98
reviewed
Oct 2, 2024
| @@ -1,6 +1,6 @@ | |||
| assembly-versioning-scheme: MajorMinorPatch | |||
| mode: ContinuousDeployment | |||
| next-version: 0.2.0 | |||
| next-version: 0.4.0 | |||
There was a problem hiding this comment.
Should we go from 0.2.0 to 0.3.0 instead of 0.4.0?
carlh98
reviewed
Oct 2, 2024
| @@ -38,7 +37,7 @@ public interface IDynamicMapComponent | |||
| /// <summary> | |||
| /// Informs the view-model that an empty area of the map was tapped. | |||
| /// </summary> | |||
| Action<Geocoordinate> OnMapTapped { get; set; } | |||
| Action<Windows.Devices.Geolocation.Geocoordinate> OnMapTapped { get; set; } | |||
There was a problem hiding this comment.
can we use using wdg = Windows.Devices.Geolocation;
carlh98
reviewed
Oct 2, 2024
| </PackageReference> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0-android'"> | ||
| <PackageReference Include="Xamarin.GooglePlayServices.Base"> | ||
| <Version>117.6.0.3</Version> |
There was a problem hiding this comment.
downgrade is wanted for android and ios?
carlh98
reviewed
Oct 2, 2024
| <PackageReference Include="Uno.Extensions.Logging.OSLog"> | ||
| <Version>1.4.0</Version> | ||
| <Version>1.4.0</Version> |
There was a problem hiding this comment.
possible to put package reference in one line with version
carlh98
reviewed
Oct 2, 2024
| @@ -1,9 +1,7 @@ | |||
| <Project Sdk="MSBuild.Sdk.Extras/3.0.44"> | |||
There was a problem hiding this comment.
If possible, use conventional commits for the commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Target recent sdk. Sample head removed to be rebuilt with latest structure
What is the current behavior?
What is the new behavior?
Checklist
Please check if your PR fulfills the following requirements:
Other information