Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash on Version and when version set to msbuild property #73

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented May 13, 2024

Fixes: #74
Fixes: #75

Proposed Changes

  • Bug fix

What is the current behavior?

Updater crashes when

  • csproj includes Version property
  • PackageVersion set to build property

What is the new behavior?

No crashes

Checklist

Please check if your PR fulfills the following requirements:

  • [N/A] Documentation has been added/updated
  • [ - ] Automated Unit / Integration tests for the changes have been added/updated
  • Contains NO breaking changes
  • [N/A] Updated the Changelog
  • Associated with an issue

Other information

@nickrandolph nickrandolph marked this pull request as ready for review May 13, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when PackageVersion is set to build property Crash when "Version" property exists in csproj
1 participant