Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watcher): add symbol queries for ruby rspec tests #308

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

wassimk
Copy link
Contributor

@wassimk wassimk commented Oct 31, 2023

I've been using these symbols queries via ruby-lsp1 on a Ruby on Rails RSpec application for the past few weeks with success. The watcher feature is so useful!

Most RSpec classes look like this:

RSpec.describe MyClass do
  it "my first test" do
    # ...
  end
end

It also covers name spaced modules like so, MyClass is the returned symbol.

RSpec.describe NameSpaceModule1::NameSpace2::MyClass do
  it "my first test" do
    # ...
  end
end

References:

Footnotes

  1. https://github.com/Shopify/ruby-lsp

I've been using these symbols queries via ruby-lsp[^1] on a Ruby on
Rails RSpec application for the past few weeks with success. The watcher
feature is so useful!

Most RSpec classes look like this:

```ruby
RSpec.describe MyClass do
  it "my first test" do
    # ...
  end
end
```

It also covers name spaced modules like so, `MyClass` is the returned
symbol.

```ruby
RSpec.describe NameSpaceModule1::NameSpace2::MyClass do
  it "my first test" do
    # ...
  end
end
```

References:
[^1]: https://github.com/Shopify/ruby-lsp
@rcarriga
Copy link
Collaborator

Thanks for the PR! 😄

@rcarriga rcarriga merged commit 4e97566 into nvim-neotest:master Dec 22, 2023
@wassimk wassimk deleted the wm/add-ruby-symbol-queries branch December 22, 2023 10:16
@wassimk wassimk restored the wm/add-ruby-symbol-queries branch December 22, 2023 17:43
@wassimk wassimk deleted the wm/add-ruby-symbol-queries branch December 22, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants