nwsnapshot fails silently ~25% of the time.

[miklschmidt]

nwsnapshot says everything is good. But loading the resulting snapshot doesn't work (nw crashes). I get errors like these at random in my code: Uncaught TypeError: Property 'ToInteger' of object [object builtins] is not a function (output on commandline)

This is happening in 0.7.x and has kept me from updating from 0.6.x for quite a while now. Haven't tried 0.8.x yet. It has been the cause of several headaches :( .. Can't figure out what the hell is happening. Any ideas? it seems broken to me..

---

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

[alexjm]

Making snapshots work would be such awesomeness. :D

[miklschmidt]

@alexjm indeed!

[alexjm]

If snapshots happen I will be overjoyed!

[miklschmidt]

@alexjm just roll back to 0.6.3, i find it to be the golden version where everything works (mostly) ;)

[rogerwang]

@miklschmidt It's a a little surprise to me. We tend to have no regressions between updates. Though we don't have enough test cases to cover it. Could you please list the regressions on your side beside this issue?

[miklschmidt]

@rogerwang i have a few issues listed on here already about the screen boundaries, those were the once i was referring to. #1152 #1133.
It's a niche issue, and i think i found a way to work around most of it, but it still yields some funky results in some situations.

I wasn't trying to bash your work or anything, what you've accomplished with node-webkit is amazing, and i can't thank you enough for the awesome work you've done!

[miklschmidt]

@rogerwang I checked your tests, and it looks like all you do is checking if the process exited? That's exactly what happens most of the time with a bad snapshot, so you're probably getting a lot of false positives.

To solve the problem, I set out to create node-nw-snapshot, which is a build server for compiling and testing snapshots cross platform. I currently have a test in there that will show you the ratio of snapshot failures. Hopefully it'll help fix the problem, or at least give others some peace of mind. It makes me sleep much better at night, knowing that i haven't deployed a bad one :)

[miklschmidt]

it seems like this won't be fixed.. It's okay though, i got your back. Just use node-nw-snapshot. I'm gonna go ahead and close this issue.

[rogerwang]

@miklschmidt thanks. we still want to fix it. After nw13 we plan to promote this feature from experimental, at that time will look into this again.

[miklschmidt]

@rogerwang sounds good! looking forward to it.

[rogerwang]

there is a new tool for this feature in 0.12.0-rc1, which removes the size limitation. please try it: https://groups.google.com/d/msg/nwjs-general/Sykci3Qhgus/AoF0zT7TEIoJ