From fa4b816e0fff17d7b843dec144da64c59104a58c Mon Sep 17 00:00:00 2001
From: Robert Nagy <ronagy@icloud.com>
Date: Tue, 13 Apr 2021 00:54:24 +0200
Subject: [PATCH] stream: fix multiple Writable.destroy() calls

Calling Writable.destroy() multiple times in the same tick
could cause an assertion error.

Fixes: https://github.com/nodejs/node/issues/38189

PR-URL: https://github.com/nodejs/node/pull/38221
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Backport-PR-URL: https://github.com/nodejs/node/pull/38473
---
 lib/internal/streams/writable.js              |  2 ++
 test/parallel/test-stream-writable-destroy.js | 11 +++++++++++
 2 files changed, 13 insertions(+)

diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
index fbc0532681b83d..eeed1df3eed53c 100644
--- a/lib/internal/streams/writable.js
+++ b/lib/internal/streams/writable.js
@@ -770,6 +770,8 @@ ObjectDefineProperties(Writable.prototype, {
 const destroy = destroyImpl.destroy;
 Writable.prototype.destroy = function(err, cb) {
   const state = this._writableState;
+
+  // Invoke pending callbacks.
   if (!state.destroyed) {
     process.nextTick(errorBuffer, state, new ERR_STREAM_DESTROYED('write'));
   }
diff --git a/test/parallel/test-stream-writable-destroy.js b/test/parallel/test-stream-writable-destroy.js
index 9f6136923ee176..f3ca402d5b3f94 100644
--- a/test/parallel/test-stream-writable-destroy.js
+++ b/test/parallel/test-stream-writable-destroy.js
@@ -417,3 +417,14 @@ const assert = require('assert');
   }));
   write.write('asd');
 }
+
+{
+  // Destroy twice
+  const write = new Writable({
+    write(chunk, enc, cb) { cb(); }
+  });
+
+  write.end(common.mustCall());
+  write.destroy();
+  write.destroy();
+}