Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata fetch bug for new Facebook contacts #418

Open
Robi9 opened this issue Feb 14, 2022 · 1 comment
Open

Metadata fetch bug for new Facebook contacts #418

Robi9 opened this issue Feb 14, 2022 · 1 comment

Comments

@Robi9
Copy link
Contributor

Robi9 commented Feb 14, 2022

With the union of the Instagram handler with the Facebook handler, an update was carried out in the search for the metadata for new contacts, which ended up influencing the appearance of a bug in the creation of these new contacts, this caused some Facebook contacts to be created without the username.

@norkans7
Copy link
Contributor

I think you mean this change https://github.com/nyaruka/courier/pull/392/files#diff-799bba3fe4dcf9897cf02b0de8b0701a579fdb1799382d109cc97a268662d1d6L653-L657

the method takes a channel in the arguments I think you can use the channel type to do the right thing for each.

Open a PR for that and remember tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants