-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support analysis of tracked files #1033
Comments
cc @dsully |
IMO onefetch should do one or the other -- analyze filesystem or git rev. Supporting both would be too complex IMO. So, besides thinking of how this could be done, I think we should ask if this should be done. This would be a significant change and most likely mark a v3 release. |
Thanks, I got busy over the weekend. Agreed on not changing the contents of the repository. FWIW, my expectation was for |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary 💡
Converting this comment chain into an issue for discussion/triage: #26 (comment)
Onefetch currently analyzes the filesystem via tokei. However, it seems like some users expect behavior more like
github-linguist
, which analyzes the language stats of tracked changes (AFAIK it analyzes a rev, defaulting to HEAD).Utilizing
git ls-files
can be a partial solution, but it will be buggy:git ls-files
.We could potentially hack it by stashing changes and restoring them after analysis. But I'm hesitant to have onefetch change the contents of a repository, even temporarily.
Motivation 🔦
There was some initial confusion brought up in #26 (comment), where a large number of untracked files significantly changed the results compared to what the user was expecting.
The text was updated successfully, but these errors were encountered: