Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket upgrades are not yet supported on native Deno requests. #345

Closed
justinmchase opened this issue Jun 24, 2021 · 2 comments
Closed

Socket upgrades are not yet supported on native Deno requests. #345

justinmchase opened this issue Jun 24, 2021 · 2 comments
Labels
external This relates to an external issue

Comments

@justinmchase
Copy link

Why not?

https://github.com/oakserver/oak/blob/main/context.ts#L190

What would be involved with making this work?

@kitsonk kitsonk added the external This relates to an external issue label Jun 24, 2021
@kitsonk
Copy link
Collaborator

kitsonk commented Jun 24, 2021

This is mentioned in the README.

Limited by Deno supporting it (see: denoland/deno#10211)

@justinmchase
Copy link
Author

justinmchase commented Jun 25, 2021

Great. I am not totally sure what I did, I think I must have started using the --unstable flag for a different reason, but now its all working as expected.

It would be really great if the error it throws on line 190 would include a link to that documentation and / or a brief description of how to fix it such as maybe:

throw new TypeError(
   "Socket upgrades are not yet supported on native Deno requests. Try adding the --unstable flag or for alternate solutions please visit https://github.com/oakserver/oak#deno-stdhttp-versus-native-bindings",
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external This relates to an external issue
Projects
None yet
Development

No branches or pull requests

2 participants