[VL] SusbtraitToVeloxPlan error

[FelixYBW]

Describe the bug
Observed by customer

To Reproduce
customer env.

[FelixYBW]

@jinchengchenghh @rui-mo @JkSelf Looks it's another case which passed validation but failed on execution. Is GetFlatConditions a sql function?

[jinchengchenghh]

No. This is in SubstraitToVelox plan conversion, SelectionNode is not suported. which should be validated but seems not.

[JkSelf]

The filter condition may be scalar, AND, OR expression. The SelectionNode may be the core case.

[JkSelf]

@FelixYBW Can we get the physical plan for this case?

[rui-mo]

Tried to throw exception in flattenConditions as below.

void SubstraitVeloxPlanConverter::flattenConditions(
    const ::substrait::Expression& substraitFilter,
    std::vector<::substrait::Expression_ScalarFunction>& scalarFunctions,
    std::vector<::substrait::Expression_SingularOrList>& singularOrLists,
    std::vector<::substrait::Expression_IfThen>& ifThens) {
  VELOX_FAIL("Failed.");

But found the validation could take effect and scan fallbacked with success, so I'm not sure why fallback does not occur in this issue.

WARNING: Logging before InitGoogleLogging() is written to STDERR
E0303 10:28:57.100342 3581697 Exceptions.h:68] Line: ../../velox/substrait/SubstraitToVeloxPlan.cpp:1066, Function:flattenConditions, Expression:  Failed., Source: RUNTIME, ErrorCode: INVALID_STATE
ReadRel validation failed due to:Failed.

[jinchengchenghh]

What's the config spark.gluten.sql.enable.native.validation? It should be true, I cannot find any code path can run to here with validation

[jinchengchenghh]

Can we close this issue, it should have been fixed by https://github.com/oap-project/gluten/pull/952/files