Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compute pid metric in shuffle operator. #1039

Closed
Yohahaha opened this issue Feb 27, 2023 · 2 comments
Closed

Remove compute pid metric in shuffle operator. #1039

Yohahaha opened this issue Feb 27, 2023 · 2 comments
Labels
CORE works for Gluten Core enhancement New feature or request

Comments

@Yohahaha
Copy link
Contributor

As discussed in #998 (comment).

To remove this, we need to change common interface io/glutenproject/vectorized/SplitResult, both Velox backend and CK backend need to apply this change.
@Yohahaha Yohahaha added the enhancement New feature or request label Feb 27, 2023
@Yohahaha Yohahaha mentioned this issue Feb 27, 2023
Closed
@Yohahaha
Copy link
Contributor Author

Hi @zzcclp, Does this metric is used in CH backend?

@zzcclp
Copy link
Contributor

zzcclp commented Feb 27, 2023

Please leave this metric, I will raise another pr to modify some metrics about the CH backend.

@weiting-chen weiting-chen added the CORE works for Gluten Core label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CORE works for Gluten Core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weiting-chen @zzcclp @Yohahaha