Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Managed memory leak in imported Spark UTs #1068

Closed
zhztheplayer opened this issue Mar 3, 2023 · 8 comments
Closed

[VL] Managed memory leak in imported Spark UTs #1068

zhztheplayer opened this issue Mar 3, 2023 · 8 comments
Labels
bug Something isn't working velox backend works for Velox backend

Comments

@zhztheplayer
Copy link
Member

Errors with "Managed memory leak detected" are being reported from the import Spark UTs.

The errors were ignored since we set "spark.unsafe.exceptionOnMemoryLeak=false" in tests.

We should deal with all of the current reported leak issues then finally set "spark.unsafe.exceptionOnMemoryLeak=true".

@zhztheplayer zhztheplayer added the bug Something isn't working label Mar 3, 2023
@zhztheplayer zhztheplayer changed the title Managed memory leak in imported Spark UTs [VL] Managed memory leak in imported Spark UTs Mar 3, 2023
@zhztheplayer
Copy link
Member Author

Tracking:

531 / 6341 UT cases are now leaking

https://gist.github.com/zhztheplayer/40cbdd0be9502fa01d8397eaa087e74a

@zhztheplayer
Copy link
Member Author

Fix #1079 submitted for leak caused by iterator unconsumed data

@zhztheplayer
Copy link
Member Author

zhztheplayer commented Mar 6, 2023

Add: Using debugging PR #1033 to count on leaked test cases

@zhztheplayer
Copy link
Member Author

Tracking:

531 / 6341 UT cases are leaking within #1079

Although #1079 fixes leak from some corner cases (e.g. TestOperator.scala which is out of this tracking)

https://gist.github.com/zhztheplayer/9baf7566bd03d570286b9281be567043

@zhztheplayer
Copy link
Member Author

Fix #1084 submitted for leak caused by Java side complex Arrow vector creation

@zhztheplayer
Copy link
Member Author

Tracking:

0 / 6341 UT cases are leaking within #1084

https://gist.github.com/zhztheplayer/b61fbf71af47d114eacb365ca7e33332

@zhztheplayer
Copy link
Member Author

zhztheplayer commented Mar 8, 2023

PR #1087 submitted to enable leak error reporting (which was previously warning) in Spark UT

@zhztheplayer
Copy link
Member Author

Closing as resolved.

@github-project-automation github-project-automation bot moved this to 🆕 New in Gluten 0.5.0 Apr 2, 2023
@weiting-chen weiting-chen added the velox backend works for Velox backend label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working velox backend works for Velox backend
Projects
None yet
Development

No branches or pull requests

2 participants