Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Spark Shim Provider found for 3.2.0 #913

Closed
puchengy opened this issue Feb 3, 2023 · 6 comments · Fixed by #932
Closed

No Spark Shim Provider found for 3.2.0 #913

puchengy opened this issue Feb 3, 2023 · 6 comments · Fixed by #932
Labels
CORE works for Gluten Core enhancement New feature or request

Comments

@puchengy
Copy link

puchengy commented Feb 3, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

We run Spark-3.2 in house, when trying gluten + velox, we see issue "No Spark Shim Provider found for 3.2.0".

Describe the solution you'd like

Support Spark 3.2.0 version.

Describe alternatives you've considered

No alternatives I can think of right now.

Additional context

Nan.

@puchengy puchengy added the enhancement New feature or request label Feb 3, 2023
@puchengy
Copy link
Author

puchengy commented Feb 3, 2023

by any chance we can provide more flexibility over the spark minor version?

@CodingCat
Copy link
Contributor

we need to run tests against a new version when adding a new minor one , because Spark seems not as compatible as years before over minor versions, <= might be a challenge given the current CI seems already slow

I had an internal patch to support minor versions and particularly I tested against 3.2.0 ....but may need to sync with intel folks before I submitted a PR

cc @FelixYBW

@FelixYBW
Copy link
Contributor

FelixYBW commented Feb 3, 2023

@CodingCat Thank you. Sure, can you submit the PR? and mention it's not tracked by our CI tests in documents?

@puchengy, As @CodingCat mentioned exactly, Spark's API changed on minor versions, so each minor version needs some patches. But our CI already take more than 1 hour, it's not possible to track on minor versions. So we can add the minor version support but it won't be tracked by CI tests. So we decided only support dedicated versions now. We can accept the minor version support PR but will document clearly on this.

@puchengy
Copy link
Author

puchengy commented Feb 3, 2023

@FelixYBW Thank you, do we have easy enough steps to run CI for the minor version (spark-3.2.0)?

If so, my team can run these CI internally whenever we plan on a new release. Thanks

@FelixYBW
Copy link
Contributor

FelixYBW commented Feb 3, 2023

Yes, the CI script is in the repo. @zhztheplayer How @puchengy can start from?

@zhztheplayer
Copy link
Member

Velox's GitHub Action CI job is basically capable for being ran from another environment:

https://github.com/oap-project/gluten/blob/3a8e7174f748aafb34cda56b289a65e9e41ae078/.github/workflows/unittests.yml#L58-L115

The job is docker-based so is portable. You can replay the steps in your machine after installing a docker service.

@weiting-chen weiting-chen added the CORE works for Gluten Core label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core enhancement New feature or request
Projects
None yet
5 participants