Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-1205][VL] Rename some class name and dir name for columnar sh… #1334

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

CLTFOREVER
Copy link
Contributor

@CLTFOREVER CLTFOREVER commented Apr 11, 2023

What changes were proposed in this pull request?

Rename some class name:
(1)SplitterBase -> ShuffleWriter
(2)Splitter -> ArrowShuffleWriter
(3)CelebornSplitter->CelebornShuffleWriter
(3)VeloxSplitter -> VeloxShuffleWriter
(4)VeloxxxxSpliter ->VeloxxxxShuffleWriter
(5)CelebornxxxSpliter->CelebornxxxShuffleWriter
and some dir name:
operators/shuffle->shuffle

(Fixes: #1205)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

#1205

@CLTFOREVER CLTFOREVER force-pushed the gluten-1205 branch 2 times, most recently from c3cc3cf to 10d6087 Compare April 11, 2023 14:16
@zuochunwei zuochunwei self-requested a review April 12, 2023 02:04
@zuochunwei
Copy link
Contributor

well done, it's ok for me

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zuochunwei zuochunwei merged commit 78bdb42 into apache:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Improve shuffle API
3 participants