[GLUTEN-1346][VL] Support native velox row to column #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchengchenghh
force-pushed
the
veloxr2c
branch
from
96abe4d to
4e436b2
Compare
jinchengchenghh
force-pushed
the
veloxr2c
branch
2 times, most recently
from
9a8a0b6 to
ffbf172
Compare
FelixYBW
reviewed
Apr 18, 2023
| std::shared_ptr<RowToColumnarConverter> VeloxBackend::getRowToColumnarConverter( | ||
| MemoryAllocator* allocator, | ||
| struct ArrowSchema* cSchema) { | ||
| // TODO: wait to fix task memory pool |
There was a problem hiding this comment.
Have you create an issue for it? let's put the issue number here
There was a problem hiding this comment.
Yes, the title is issue number
There was a problem hiding this comment.
I mean the memory pool issue
FelixYBW
reviewed
Apr 18, 2023
| val DEBUG: Boolean = { | ||
| SQLConf.get | ||
| .getConfString("spark.gluten.sql.memory.debug", "false").toBoolean | ||
| .getConfString("spark.gluten.sql.memory.debug", "true").toBoolean |
There was a problem hiding this comment.
It can be true, still need java VM Options -ea to open Arrow debug mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.