[GLUTEN-1367] Support running gluten on anolis #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohahaha
reviewed
Apr 15, 2023
| @@ -40,6 +40,10 @@ class VeloxInitializerApi extends InitializerApi { | |||
| new VeloxSharedlibraryLoaderCentos7 | |||
| } else if (system.contains("alinux") && system.contains("3")) { | |||
| new VeloxSharedlibraryLoaderCentos8 | |||
| } else if (system.contains("Anolis") && system.contains("8")) { | |||
| new VeloxSharedlibraryLoaderCentos8 | |||
| } else if (system.contains("Anolis") && system.contains("7")) { | |||
There was a problem hiding this comment.
Alinux3 is verified with Alibaba cloud EMR release version 5.11.1
I'm not sure Anolis7/8 is supported too.
How do you test it?
There was a problem hiding this comment.
@Yohahaha Thanks for your review, we use our own basic image with anolis 8 with spark and only modify the VeloxInitializerApi in gluten and do not modify centos set.up script.
There was a problem hiding this comment.
Thanks for clarify, make sense for me.
cc @FelixYBW @zhejiangxiaomai
FelixYBW
approved these changes
Apr 17, 2023
|
@FelixYBW this PR would be landed, thanks. |
zhejiangxiaomai
approved these changes
Apr 18, 2023
|
If CI pass, I will merge this pr. |
|
retest this please |
It seems that there is still a problem with retest. |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #1367)
How was this patch tested?
manual tests on anolis