[GLUTEN-1369][Core] Move config 'spark.gluten.enabled' to GlutenConfig from QueryPlanSelector #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the config 'spark.gluten.enabled' to GlutenConfig
rui-mo
previously approved these changes
Apr 19, 2023
leesf
reviewed
Apr 20, 2023
| @@ -254,4 +256,16 @@ class GlutenClickHouseTPCHColumnarShuffleParquetAQESuite | |||
| assert(adaptiveSparkPlanExec(1) == adaptiveSparkPlanExec(2)) | |||
| } | |||
| } | |||
|
|
|||
| test("Test 'spark.gluten.enabled' false") { | |||
| withSQLConf(("spark.gluten.enabled", "false")) { | |||
There was a problem hiding this comment.
is it needed to set spark.gluten.enabled to false and true to run test?
There was a problem hiding this comment.
not needed, the other test cases run with spark.gluten.enabled true,
|
it seems there are some networks issue for velox-backend-centos7-test @rui-mo |
rui-mo
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move the config 'spark.gluten.enabled' to GlutenConfig from QueryPlanSelector
(Fixes: #1369 )
Close #1369 .
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)