[GLUTEN-1476][VL] Support GetStructField #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
cc @liujiayi771 |
|
Depends on #1878. |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
JkSelf
reviewed
Jun 9, 2023
| @@ -353,7 +353,11 @@ class VeloxDataTypeValidationSuite extends WholeStageTransformerSuite { | |||
| // Validation: BatchScan Project Aggregate Sort Limit | |||
| // TODO validate Expand operator support Struct type ? | |||
| runQueryAndCompare("select int, struct.struct_1 from type1 " + | |||
| "sort by struct.struct_1 limit 1") { _ => } | |||
| "sort by struct.struct_1 limit 1") { df => { | |||
There was a problem hiding this comment.
Do we need to add the nested struct type test？
There was a problem hiding this comment.
There are several tests from Spark on that in GlutenDataFrameSetOperationsSuite and were fixed.
This reverts commit f3ed0aa.
|
Run Gluten Clickhouse CI |
|
@JkSelf Could you help review again? Just reverted the test branch. |
JkSelf
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support GetStructField on Velox backend.
oap-project/velox#294
#1476
How was this patch tested?
under test