-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] add support for reading ORC #1513
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@zuochunwei Can you also add some orc test in gluten unit test scala side to check whether offload to native and the correctness? |
I have added what |
We can read an orc file to check whether the scan operator can be offloaded and then verify the correctness to compare with vanilla spark. We can also add the orc file format test in TPC-H/DS later. |
@zuochunwei You may need to change the velox repo and branch here if you changed the velox code. |
I proposed a corresponding PR for |
We have tested read orc file through the TableScan operator, and it's OK |
Here is a example to use your local branch to test gluten CI. @zuochunwei |
OK, thank you! |
@zuochunwei I tested orc scan in gluten with following unit test. It can work. Can you add this unit test in TestOperator.scala in this PR? And we can add the orc file format test in TPC-H/DS in the following PRs later.
|
done |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
5 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Co-authored-by: yangyimin <yangyimin@meituan.com>
Run Gluten Clickhouse CI |
run |
Run Gluten Clickhouse CI |
Co-authored-by: yangyimin <yangyimin@meituan.com>
Run Gluten Clickhouse CI |
Co-authored-by: yangyimin <yangyimin@meituan.com>
Run Gluten Clickhouse CI |
Co-authored-by: yangyimin <yangyimin@meituan.com>
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
What changes were proposed in this pull request?
add support for reading ORC files encoded with RLE v1/v2
the PR oap-velox orc supprt should be merged before this PR
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)