Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-1476][CORE] Use correct field name in struct type #1878

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Jun 7, 2023

What changes were proposed in this pull request?

In Velox, field names are used in native struct reader, and getStructField. This PR added names field in Substrait struct type.
Depends on: oap-project/velox#297.

#1476

How was this patch tested?

Testing on CI.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

#1476

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Run Gluten Clickhouse CI

@rui-mo rui-mo requested a review from zzcclp June 8, 2023 00:00
@rui-mo rui-mo changed the title [GLUTEN-1476][VL] Use correct field name in struct type [GLUTEN-1476][CORE] Use correct field name in struct type Jun 8, 2023
zzcclp
zzcclp previously approved these changes Jun 8, 2023
Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 20bdbdd into apache:main Jun 8, 2023
@rui-mo rui-mo deleted the wip_name branch October 25, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants